Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr title 规范应与 commit message 规范统一 #3711

Closed
1 task
Ir1d opened this issue Dec 24, 2021 · 0 comments · Fixed by #3721
Closed
1 task

pr title 规范应与 commit message 规范统一 #3711

Ir1d opened this issue Dec 24, 2021 · 0 comments · Fixed by #3721
Labels
Content Bug / 页面内容有误 Something isn't working help wanted / 需要帮助 Extra attention is needed

Comments

@Ir1d
Copy link
Member

Ir1d commented Dec 24, 2021

请选择：

  • 我正在着手修复这个问题

我正在访问这个页面

https://oi-wiki.org/intro/htc/#pull-request

我发现页面有这样的问题

目前的两个规范本质上是一致的，只是需要翻译一下 （feat，fix）这种功能词。建议统一，以免在 squash 的时候产生对 pr title 的不必要的修改 （#3661）
@Ir1d Ir1d added Content Bug / 页面内容有误 Something isn't working help wanted / 需要帮助 Extra attention is needed labels Dec 24, 2021
@Ir1d Ir1d mentioned this issue Dec 24, 2021
Merged
renbaoshuo added a commit to renbaoshuo/OI-wiki that referenced this issue Dec 26, 2021
@renbaoshuo
fix(intro/htc): pr title 规范应与 commit message 规范统一 (OI-wiki#3711)
3e285bc
@CoelacanthusHex CoelacanthusHex mentioned this issue Dec 26, 2021
Merged
Enter-tainer pushed a commit that referenced this issue Dec 27, 2021
@renbaoshuo @CoelacanthusHex
fix(intro/htc): pr title 规范应与 commit message 规范统一 (#3711) (#3721)
471f1b9 
Co-authored-by: Coelacanthus <coelacanthus@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content Bug / 页面内容有误 Something isn't working help wanted / 需要帮助 Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(intro/htc): pr title 规范应与 commit message 规范统一 (#3711) renbaoshuo/OI-wiki
1 participant
@Ir1d