Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret masking - Hide secret codes in log output - v1 #10

Merged
merged 2 commits into from Nov 29, 2017

Conversation

jasonish
Copy link
Member

@jasonish jasonish commented Nov 29, 2017

Allows secrets to be registered with the logger that will be masked. For now this just means the ET Pro code which is now logged like:

28/11/2017 -- 21:22:14 - <Info> -- Checking https://rules.emergingthreatspro.com/<code>/suricata-4.1.0/etpro.rules.tar.gz.md5.

Redmine issue:
https://redmine.openinfosecfoundation.org/issues/2259

Allows strings to be registered that will be masked
in the log output.
@jasonish jasonish requested a review from a team as a code owner November 29, 2017 03:27
Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and tests ok.

@jasonish jasonish merged commit ad4f749 into OISF:master Nov 29, 2017
@jasonish jasonish deleted the secret-masking-1 branch November 29, 2017 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants