Fix default for the --ignore flag #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suricata-update doesn't properly load some sections in update.yaml file. Example: Even after setting the following in update.yaml ``` ignore: - "*deleted.rules" - "*pop3.rules" ``` ``` $ ./bin/suricata-update -v ``` generates ``` 16/3/2019 -- 03:14:59 - <Debug> -- Parsing rules/emerging-pop3.rules. 16/3/2019 -- 03:15:01 - <Debug> -- Parsing rules/emerging-deleted.rules. ``` which means the files do not get ignored. It seems that the code loading command line parameters override previous settings even when no parameters are given. Thus changing the default for the --ignore flag from "[]" to "None", fixes the issue. Closes Redmine ticket #2851.
|
@shivan1b Could you please review the changes and let me know if all the contribution guidelines are followed or if any changes are needed? |
|
Thanks for this fix, this issue effectively broke the ignore functionality for us. |
|
Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suricata-update doesn't properly load some sections in update.yaml file.
Example:
Even after setting the following in update.yaml
generates
which means the files do not get ignored. It seems that the code loading command line parameters override previous settings even when no parameters are given.
Thus changing the default for the --ignore flag from "[]" to "None", fixes the issue.
Make sure these boxes are signed before submitting your Pull Request
-- thank you.
https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
contribution agreement at
https://suricata-ids.org/about/contribution-agreement/
changes made (if applicable)
Link
to
redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2851
Describe changes:
Fixes default for the --ignore flag from "[]" to "None"