Parse rule files alphabetically #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the file names before parsing them. Example: Currently, ``` suricata-update -v ``` generates ``` 24/3/2019 -- 10:38:16 - <Debug> -- Parsing rules/emerging-chat.rules. 24/3/2019 -- 10:38:16 - <Debug> -- Parsing sslblacklist.rules. 24/3/2019 -- 10:38:16 - <Debug> -- Parsing rules/emerging-web_client.rules. 24/3/2019 -- 10:38:16 - <Debug> -- Parsing rules/botcc.portgrouped.rules. 24/3/2019 -- 10:38:16 - <Debug> -- Parsing rules/emerging-smtp.rules. ``` i.e., the rule files are not parsed in alphabetical order. Thus, changing the parser to load these files in alphabetical order by sorting the filenames before starting to work on them fixes the issue. Now the output generated on running ``` suricata-update -v ``` is ``` 24/3/2019 -- 10:34:24 - <Debug> -- Parsing rules/botcc.rules. 24/3/2019 -- 10:34:24 - <Debug> -- Parsing rules/ciarmy.rules. 24/3/2019 -- 10:34:24 - <Debug> -- Parsing rules/compromised.rules. 24/3/2019 -- 10:34:24 - <Debug> -- Parsing rules/drop.rules. 24/3/2019 -- 10:34:24 - <Debug> -- Parsing rules/dshield.rules. 24/3/2019 -- 10:34:24 - <Debug> -- Parsing rules/emerging-activex.rules. ``` Rules files are now parsed in sorted order. Closes Redmine ticket #2892
jasonish
approved these changes
May 26, 2019
|
Merged into master. Thanks, @vidushi4 ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the file names before parsing them.
Example:
Currently,
generates
i.e., the rule files are not parsed in alphabetical order.
Thus, changing the parser to load these files in alphabetical order by sorting the filenames before starting to work on them fixes the issue. Now the output generated on running
is
Rules files are now parsed in sorted order.
Closes Redmine ticket #2892
Make sure these boxes are signed before submitting your Pull Request
-- thank you.
https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
contribution agreement at
https://suricata-ids.org/about/contribution-agreement/
changes made (if applicable)
Link
to
redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2892
Describe changes:
Updated main.py to to load rule files in alphabetical order by sorting the filenames before starting to work on them.