Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing --http-header option #232

Closed
wants to merge 1 commit into from

Conversation

michaelschem
Copy link
Contributor

@michaelschem michaelschem commented May 13, 2020

Make sure these boxes are signed before submitting your Pull Request
-- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3696

Describe changes:

  • In the main.py file, http_header was incorrectly being used as a key to get the http-header value from sources. The key was updated to http-header to fix this.

@michaelschem
Copy link
Contributor Author

The option --http-header documented here can set an additional header. It is saved in the /var/lib/suricata/update/sources directory in a yaml, but main.py isn't able to be retrieved it due to using the an underscore (_) instead of a hyphen (-) in the key http-header.

@michaelschem michaelschem changed the title changing source index from http_header to http-header to fix --http_h… Fixing --http-header option May 15, 2020
@jasonish
Copy link
Member

Merged. Thanks!

@jasonish jasonish closed this May 28, 2020
@michaelschem michaelschem deleted the fix_http_header branch May 28, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants