Add warning to update sources if no index found

[TharushiJay]

• I have read the contributing guide lines at
  https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
• I have signed the Open Information Security Foundation
  contribution agreement at
  https://suricata-ids.org/about/contribution-agreement/
• I have updated the user guide (in doc/userguide/) to reflect the
  changes made (if applicable)

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/3249

Describe changes:

• Don't automatically update the sources on list-sources if it does not exist. Instead just use the bundled version.

[inashivb]

Thanks for your first contribution to the project! :)
I'll wait for Jason to respond but since its very close to completion, you can now claim another ticket.

Good job!

[TharushiJay]

Great! Thank you Shivani. I really enjoyed working on this project.

…

On Thu, 8 Oct 2020, 11:20 pm Shivani, ***@***.***> wrote: Thanks for your first contribution to the project! :) I'll wait for Jason to respond but since its very close to completion, you can now claim another ticket. Good job! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#259 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGRWHJVK5UFDE3WLFWMDETLSJX3XLANCNFSM4SJACEKA> .

[jasonish]

Thanks. Code looks good, tests OK.

As this does change the behaviour I'd like to see more info in the commit message. The first line of the message is fine. But the body of the commit message should contain a little more detail along the lines of:

Don't automatically update the sources on list-sources if it does not exist. Instead just use the bundled version.

[TharushiJay]

Thanks. Code looks good, tests OK.

As this does change the behaviour I'd like to see more info in the commit message. The first line of the message is fine. But the body of the commit message should contain a little more detail along the lines of:

Don't automatically update the sources on list-sources if it does not exist. Instead just use the bundled version.

@jasonish I updated the body of the commit message (under 'Describe changes') to reflect the details you mentioned. Is there anything else I could change to get this PR approved?

[jasonish]

Thanks. Code looks good, tests OK.
As this does change the behaviour I'd like to see more info in the commit message. The first line of the message is fine. But the body of the commit message should contain a little more detail along the lines of:
Don't automatically update the sources on list-sources if it does not exist. Instead just use the bundled version.

@jasonish I updated the body of the commit message (under 'Describe changes') to reflect the details you mentioned. Is there anything else I could change to get this PR approved?

@TharushiJay You did update the pull request message. But I'd like the commit message to be updated as well. This can be done with the "reword" feature of a git rebase. If you are not familar with that feature, I'm happy to list out the commands here.

[TharushiJay]

@TharushiJay You did update the pull request message. But I'd like the commit message to be updated as well. This can be done with the "reword" feature of a git rebase. If you are not familar with that feature, I'm happy to list out the commands here.

Sorry, my mistake! I wasn't aware of changing the 'body of the commit message'. Thank you @jasonish. I used the reword feature and I believe the body of the commit message is now modified to reflect the changes.
Please let me know if this works.

[jasonish]

Close, again the code is fine, but the formatting of the commit message needs to be fixed. In general the first line should be something like:

Add warning to update sources if no index found

Usually this should be limited to 72 characters.

Then after that first line, leave one blank link then the body:

Don't automatically update the sources on list-sources 
if it does not exist. Instead just use the bundled version.

The body should be word-wrapped at 72 cols as well.

This all helps to provide a better reading experience in the "git log" output.

Thanks.

[jasonish]

Commit change tweaks.

[TharushiJay]

Close, again the code is fine, but the formatting of the commit message needs to be fixed. In general the first line should be something like:

Add warning to update sources if no index found

Usually this should be limited to 72 characters.

Then after that first line, leave one blank link then the body:

Don't automatically update the sources on list-sources 
if it does not exist. Instead just use the bundled version.

The body should be word-wrapped at 72 cols as well.

This all helps to provide a better reading experience in the "git log" output.

Thanks.

@jasonish Thanks for the helpful advice. I've made the necessary changes. Please let me know if this works.

[jasonish]

Looks good. Thanks!

[jasonish]

Merged in master via #292, Thanks!