Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync up with 1.0.3; enable integration tests on Travis. #84

Merged
merged 4 commits into from Dec 21, 2018
Merged

Sync up with 1.0.3; enable integration tests on Travis. #84

merged 4 commits into from Dec 21, 2018

Conversation

jasonish
Copy link
Member

Includes Redmine issues:

inashivb and others added 4 commits December 21, 2018 09:12
@inashivb @jasonish
Make header an optional argument
f52d104 
header was being used as a required argument in SourceConfiguration
class. Since SourceConfiguration class has been used multiple times
across commands, not all the commands require header argument and thus
it breaks. Fix it by making header an optional argument.

Closes redmine ticket #2753
@jasonish
changelog: update for 1.0.3
d44d734
@jasonish
travis: call integration test
413051a
@jasonish
integration test: log python version info
900f886
@jasonish jasonish requested a review from a team as a code owner December 21, 2018 15:21
shivan1b
shivan1b approved these changes Dec 21, 2018
View reviewed changes
Copy link

@shivan1b shivan1b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jasonish jasonish merged commit 900f886 into OISF:master Dec 21, 2018
@jasonish jasonish deleted the travis-integration-tests-1 branch February 13, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivan1b shivan1b shivan1b approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@jasonish @shivan1b @inashivb