Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfb: test rfb frames #1059

Closed
wants to merge 1 commit into from
Closed

rfb: test rfb frames #1059

wants to merge 1 commit into from

Conversation

hsadia538
Copy link
Contributor

@hsadia538 hsadia538 commented Jan 9, 2023 •
edited

Ticket: https://redmine.openinfosecfoundation.org/issues/5717

Previous PR: #1050

Describe new changes:

  • Update test.yaml and test.rules
  • Add configuration to test frame.direction , frame.type, and frame.complete

Requires: OISF/suricata#8337

@hsadia538 hsadia538 mentioned this pull request Jan 9, 2023
Closed
@jufajardini jufajardini added the requires suricata pr Depends on a PR in Suricata label Jan 9, 2023
jufajardini
jufajardini approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Jan 25, 2023
@jufajardini
Copy link
Contributor

Current Suricata PR: OISF/suricata#8416

@hsadia538
Copy link
Contributor Author

Followed by #1117

@hsadia538 hsadia538 closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jufajardini jufajardini jufajardini approved these changes

Assignees
No one assigned
Labels
outreachy Contributions made by Outreachy applicants requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
2 participants
@hsadia538 @jufajardini