Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smb: fix test for master6 #1162

Closed
wants to merge 1 commit into from
Closed

Conversation

catenacyber
Copy link
Collaborator

Difference with 7 is missing feature file deletion

Addition since 6.0.0 is async response cf smb2.aid wireshark filter

Ticket: #5820

@catenacyber catenacyber added the tests pass These new tests should pass label Apr 3, 2023
@victorjulien victorjulien removed the tests pass These new tests should pass label Apr 3, 2023
@victorjulien
Copy link
Member

Except they don't :)

Difference with 7 is missing feature file deletion
Addition since 6.0.0 is async response cf smb2.aid wireshark filter

Ticket: #5820
@catenacyber
Copy link
Collaborator Author

Except they don't :)

:-p they do, except SV Github CI does not do the rebase over master

@catenacyber catenacyber added the tests pass These new tests should pass label Apr 7, 2023
@victorjulien victorjulien mentioned this pull request Apr 17, 2023
@victorjulien
Copy link
Member

Merged in #1174, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests pass These new tests should pass
2 participants