Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect lua 4911 v3 #1165

Closed
wants to merge 7 commits into from
Closed

Conversation

TheKharleeci
Copy link
Contributor

@TheKharleeci TheKharleeci commented Apr 3, 2023

Includes test for LuaMatchTest01-LuaMatchTest06

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4911

Previous PR: #1086

@jufajardini jufajardini self-requested a review April 5, 2023 18:59
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheKharleeci !
Thank you for your work! :) Could you please add a README to all the tests? I'm unsure what each test is supposed to be doing to ensure if it is doing the intended thing correctly?

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there :)

Thanks for continuing to work on this task. Adding to what Shivani has requested, these tests could all be into a single commit. Could you please squash the commits and edit the commit message so it's more conforming to our standards?

We must also investigate why these are not passing, as they should be.

@inashivb inashivb mentioned this pull request Apr 18, 2023
@TheKharleeci
Copy link
Contributor Author

TheKharleeci commented May 30, 2023

I seem to have messed up my commit history, I can't seem to squash the commits and I'm not sure how to fix it. Do I create another branch?

@jufajardini
Copy link
Contributor

I seem to have messed up my commit history, I can't seem to squash the commits and I'm not sure how to fix it. Do I create another branch?

That is the easier, cleaner, and safer way - also useful for the next PR, as you keep different branch versions :P

If you are feeling adventurous, though, you can rework your history with an interactive rebase: git rebase -i HEAD~numberofcommitstoorganize. This can be messy when we're not used to it, so I recommend you create a new branch for that in any case, to practice a bit, if you are not familiar with it.

@inashivb inashivb added the outreachy Contributions made by Outreachy applicants label Jun 9, 2023
@TheKharleeci
Copy link
Contributor Author

Replaced With #1242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
3 participants