-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect lua 4911 v3 #1165
Detect lua 4911 v3 #1165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TheKharleeci !
Thank you for your work! :) Could you please add a README to all the tests? I'm unsure what each test is supposed to be doing to ensure if it is doing the intended thing correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there :)
Thanks for continuing to work on this task. Adding to what Shivani has requested, these tests could all be into a single commit. Could you please squash the commits and edit the commit message so it's more conforming to our standards?
We must also investigate why these are not passing, as they should be.
Task: 4911
I seem to have messed up my commit history, I can't seem to squash the commits and I'm not sure how to fix it. Do I create another branch? |
That is the easier, cleaner, and safer way - also useful for the next PR, as you keep different branch versions :P If you are feeling adventurous, though, you can rework your history with an interactive rebase: |
Replaced With #1242 |
Includes test for LuaMatchTest01-LuaMatchTest06
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4911
Previous PR: #1086