Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect-pcre: add tests - v6 #1604

Closed
wants to merge 1 commit into from

Conversation

jufajardini
Copy link
Contributor

Bring previously Suricata unit tests as suricata-verify tests.

Task #6147

Previous PR: #1576

Converts unit tests into sv tests:

  • detect-pcre-01: DetectPcreModifPTest04
  • detect-pcre-02: DetectPcreModifPTest05
  • detect-pcre-03: DetectPcreTestSig01-03
  • detect-pcre-04: DetectPcreTestSig09-16
  • detect-pcre-05: DetectPcreFlowvarCapture01- 03

Changes:

  • fix pcap type issue with OpenBSD (hopefully)
  • add a reference to the recently merged htptopcap script to the README of detect-pcre-02 file
  • add unittest to sv test mapping in the commit message

Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6147

Bring previously Suricata unit tests as suricata-verify tests.

Conversions mapping:
- detect-pcre-01: DetectPcreModifPTest04
- detect-pcre-02: DetectPcreModifPTest05
- detect-pcre-03: DetectPcreTestSig01-03
- detect-pcre-04: DetectPcreTestSig09-16
- detect-pcre-05: DetectPcreFlowvarCapture01- 03

Task #6147
@victorjulien
Copy link
Member

Merged in #1604, thanks!

@jufajardini jufajardini deleted the detect-pcre-4911-v6 branch January 24, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants