Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: ERSPAN Type I packet decode if config #195

Closed
wants to merge 1 commit into from
Closed

tests: ERSPAN Type I packet decode if config #195

wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

This commit adds tests for ERSPAN Type I decoding based on configuration
settings.

Requires Suricata PR #4627

@jlucovsky
tests: ERSPAN Type I packet decode if config
842401e 
This commit adds tests for ERSPAN Type I decoding based on configuration
settings.
This was referenced Mar 5, 2020
Closed
Closed
@jasonish jasonish added the requires suricata pr Depends on a PR in Suricata label Mar 20, 2020
@victorjulien
Copy link
Member

This fails for master because there we decided not to make the decoder optional. I don't think we can specify a max-version @jasonish @inashivb ?

@inashivb
Copy link
Member

inashivb commented May 4, 2020

This fails for master because there we decided not to make the decoder optional. I don't think we can specify a max-version @jasonish @inashivb ?

No, we cannot. Do we need that feature?
One way with the current options in s-v could be writing multiple tests with version:XXX? Move all the tests in a folder decode-erspan. Would that help?

@jasonish
Copy link
Member

jasonish commented May 4, 2020

No, we cannot. Do we need that feature?

I think a max-version will have its uses as we deprecate things as well.

@jasonish jasonish mentioned this pull request May 15, 2020
Closed
catenacyber
catenacyber requested changes Jul 31, 2020
View reviewed changes
Copy link
Collaborator

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test still fails after the Suricata PR got merged

tests/decode-erspan-typeI-03/test.yaml
event_type: flow

- stats:
decoder.erspan: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not pass even if the suricata PR was merged.
Sub test #2: FAIL : stats.decoder.erspan: expected 0; got 42
What is wrong ? The test or suricata ?

@jlucovsky jlucovsky mentioned this pull request Jul 31, 2020
Closed
@jlucovsky
Copy link
Contributor Author

Continued in #286

@jlucovsky jlucovsky closed this Jul 31, 2020
@jlucovsky jlucovsky deleted the 3481/1 branch August 3, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber requested changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
5 participants
@jlucovsky @victorjulien @inashivb @jasonish @catenacyber