ssl: detect duplicate client handshake #10059
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some invalid implementation of TLS have been seen where the client is sending two handshake messages at start. The result was a problem of JA3 generation. As it is invalid if we follow the RFC, let's ignore the second message.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #10059 +/- ##
==========================================
- Coverage 82.45% 82.35% -0.10%
==========================================
Files 972 972
Lines 271461 271475 +14
==========================================
- Hits 223822 223565 -257
- Misses 47639 47910 +271
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Is there a SV test ? |
|
Information: QA ran without warnings. Pipeline 17098 |
| @@ -1498,6 +1499,16 @@ static int SSLv3ParseHandshakeType(SSLState *ssl_state, const uint8_t *input, | |||
|
|
|||
| switch (ssl_state->curr_connp->handshake_type) { | |||
| case SSLV3_HS_CLIENT_HELLO: | |||
| if (ssl_state->flags & SSL_AL_FLAG_STATE_CLIENT_HELLO) { | |||
| SSLSetEvent(ssl_state, TLS_DECODER_EVENT_DUPLICATE_HANDSHAKE_MESSAGE); | |||
| if (ssl_state->client_connp.ja3_str) { | |||
There was a problem hiding this comment.
why is the ja3 stuff freed here?
victorjulien
requested changes
Jan 19, 2024
|
Information: QA ran without warnings. Pipeline 17098 |
|
Is the PCAP in https://redmine.openinfosecfoundation.org/issues/7016 useful for a test @regit ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some invalid implementation of TLS have been seen where the client is sending two handshake messages at start. The result was a problem of JA3 generation.
As it is invalid if we follow the RFC, let's ignore the second message.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6634
Describe changes: