Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: add rules skipped due to missing requirements - v10 #10078

Merged
merged 1 commit into from Dec 28, 2023

Conversation

jasonish
Copy link
Member

Rule skipped is a count of the number of rules that are skipped due to
missing requirements.

Feature: OISF#6637
@jasonish jasonish requested review from victorjulien and a team as code owners December 19, 2023 18:27
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cc872f) 82.19% compared to head (b453eea) 82.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10078      +/-   ##
==========================================
- Coverage   82.19%   82.18%   -0.01%     
==========================================
  Files         975      975              
  Lines      271940   271941       +1     
==========================================
- Hits       223523   223503      -20     
- Misses      48417    48438      +21     
Flag Coverage Δ
fuzzcorpus 62.92% <0.00%> (+<0.01%) ⬆️
suricata-verify 61.41% <100.00%> (-0.02%) ⬇️
unittests 62.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17151

@victorjulien
Copy link
Member

Does the unix socket side work too? Meaning https://github.com/OISF/suricata/blob/master/src/unix-manager.c#L771

@jasonish
Copy link
Member Author

Does the unix socket side work too? Meaning https://github.com/OISF/suricata/blob/master/src/unix-manager.c#L771

Yes, this is just a subset of dump-counters:

>>> ruleset-stats
Success:
[
    {
        "id": 0,
        "rules_failed": 1,
        "rules_loaded": 1,
        "rules_skipped": 2
    }
]

@victorjulien victorjulien added this to the 8.0 milestone Dec 28, 2023
@victorjulien victorjulien merged commit b453eea into OISF:master Dec 28, 2023
45 checks passed
@victorjulien
Copy link
Member

Merged in #10100, thanks!

@jasonish jasonish deleted the requires-keyword/v10 branch January 24, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants