Detect integers 6644 v2 #10105
Closed
Detect integers 6644 v2 #10105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can write enip.revision: 0x203 Ticket: 6645
Ticket: 6647 Allows keywords using integers to use strings in signature parsing based on a rust enumeration with a derive.
Ticket: 6648 Like &0x40=0x40 to test for a specific bit set
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10105 +/- ##
==========================================
- Coverage 82.19% 82.06% -0.13%
==========================================
Files 975 974 -1
Lines 271940 272020 +80
==========================================
- Hits 223523 223240 -283
- Misses 48417 48780 +363
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 17319 |
|
Replaced by #10110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6645
https://redmine.openinfosecfoundation.org/issues/6646
https://redmine.openinfosecfoundation.org/issues/6647
https://redmine.openinfosecfoundation.org/issues/6648
All in tracking ticket https://redmine.openinfosecfoundation.org/issues/6644 for integers as first-class detection
Describe changes:
#10089 with newer commits