Websockets 2695 v11 #10121
Closed
Websockets 2695 v11 #10121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can write enip.revision: 0x203 Ticket: 6645
catenacyber
requested review from
jasonish,
jufajardini,
victorjulien and
a team
as code owners
Closed
Ticket: 6647 Allows keywords using integers to use strings in signature parsing based on a rust enumeration with a derive.
Ticket: 6648 Like &0x40=0x40 to test for a specific bit set
Ticket: 6628 Document the generic detection capabilities for integer keywords. and make every integer keyword pointing to this section.
if no config option is found, as is done for udp Ticket: 6304
Including the one for websocket over HTTP/2
port is used in AppLayerProtoDetectProbingParserPort and not in AppLayerProtoDetectProbingParserElement
As for WebSocket which is detected only by protocol change.
When there is a protocol change, and a specific protocol is expected, like WebSeocket, always run it, no matter the port.
Ticket: 2695
catenacyber
force-pushed
the
websockets-2695-v11
branch
from
a386c6f
to
1b1fc8b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10121 +/- ##
==========================================
- Coverage 82.15% 82.08% -0.08%
==========================================
Files 974 980 +6
Lines 271925 272529 +604
==========================================
+ Hits 223394 223698 +304
- Misses 48531 48831 +300
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 17377 |
Closed
|
Replaced by #10130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2695
https://redmine.openinfosecfoundation.org/issues/6647
https://redmine.openinfosecfoundation.org/issues/6645
https://redmine.openinfosecfoundation.org/issues/6648
Describe changes:
OISF/suricata-verify#1571
#10104 with rebase to get green CI
I think this is good enough for a first version even if there may be improvements (that can happen in later tickets) :
This is a big one as websockets over HTTP/2 only use a single HTTP/2 stream and not the whole TCP connection which keeps having newer regular HTTP/2 streams
#9870 should likely precede this