detect: requires keyword (7.0.x backport) #10206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the feature module is not available for Rust unit tests, a mock version is also provided. (cherry picked from commit 15ed51f)
Add a new rule keyword "requires" that allows a rule to require specific Suricata versions and/or Suricata features to be enabled. Example: requires: feature geoip, version >= 7.0.0, version < 8; requires: version >= 7.0.3 < 8 requires: version >= 7.0.3 < 8 | >= 8.0.3 Feature: OISF#5972 Co-authored-by: Philippe Antoine <pantoine@oisf.net> (cherry picked from commit 5d5b050)
During the pre-scan for "requires", also parse the SID if possible. If the rule fails high level parsing (syntax), the SID will not be parsed. But every keyword other than "sid" and "requires" should expect to be provided with a parsed sid. (cherry picked from commit 71bbba9)
jasonish
requested review from
jufajardini,
victorjulien and
a team
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #10206 +/- ##
==============================================
- Coverage 82.37% 82.10% -0.27%
==============================================
Files 971 974 +3
Lines 274054 274579 +525
==============================================
- Hits 225747 225447 -300
- Misses 48307 49132 +825
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This is missing d321838. |
victorjulien
approved these changes
Jan 20, 2024
|
Information: QA ran without warnings. Pipeline 17659 |
|
Merged in #10211, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the requires keyword: https://redmine.openinfosecfoundation.org/issues/5972
Backport ticket: https://redmine.openinfosecfoundation.org/issues/6524
SV_BRANCH=OISF/suricata-verify#1595