detect/tls.certs: fix direction handling #10265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direction flag was checked against wrong field, leading to undefined behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10265 +/- ##
==========================================
+ Coverage 82.28% 82.31% +0.02%
==========================================
Files 977 977
Lines 271950 271950
==========================================
+ Hits 223784 223846 +62
+ Misses 48166 48104 -62
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 17800 |
|
Created a ticket: https://redmine.openinfosecfoundation.org/issues/6778 |
|
Backport required? If would, would be nice to have the ticket ID in the commit. |
Ya, done in #10405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direction flag was checked against wrong field, leading to undefined behavior.
Spotted this by accident, no ticket or test case made.