Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: 6725 add pcap file logging variable details v2 #10293

Closed
wants to merge 1 commit into from

Conversation

jmtaylor90
Copy link
Contributor

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6725

Describe changes:

  • addressed comments in previous PR
  • add pcap file name variables documentation

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Signed-off-by: jason taylor <jtfas90@gmail.com>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (244a35d) 73.31% compared to head (ef6d3b2) 82.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10293       +/-   ##
===========================================
+ Coverage   73.31%   82.33%    +9.01%     
===========================================
  Files         895      978       +83     
  Lines      148215   272029   +123814     
===========================================
+ Hits       108666   223973   +115307     
- Misses      39549    48056     +8507     
Flag Coverage Δ
fuzzcorpus 63.51% <ø> (+0.03%) ⬆️
suricata-verify 61.49% <ø> (-0.04%) ⬇️
unittests 62.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


.. note:: It is possible to use directories but the directories are not
created by Suricata. For example ``filename: pcaps/%n/log.%s`` will log into
a the pre-existing ``pcaps`` directory and per thread sub directories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: a or the :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about that, fixed up

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good to me, but spotted a sneaky typo D:

@jmtaylor90
Copy link
Contributor Author

continued in #10294

@jmtaylor90 jmtaylor90 closed this Jan 31, 2024
@jmtaylor90 jmtaylor90 deleted the 6725-doc-pcap-mode-v2 branch May 7, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants