Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustfmt 3836 v4 #10303

Closed
wants to merge 3 commits into from
Closed

Rustfmt 3836 v4 #10303

wants to merge 3 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3836

Describe changes:

  • format rust code

#10088 with rebase

@jasonish if I understand correctly, the question with this is if the C code should be formatted within the same commit than rust, what do you think ?

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 383 lines in your changes are missing coverage. Please review.

Comparison is base (244a35d) 73.31% compared to head (d95abeb) 82.38%.
Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10303       +/-   ##
===========================================
+ Coverage   73.31%   82.38%    +9.06%     
===========================================
  Files         895      978       +83     
  Lines      148215   273112   +124897     
===========================================
+ Hits       108666   225006   +116340     
- Misses      39549    48106     +8557     
Flag Coverage Δ
fuzzcorpus 63.81% <86.19%> (+0.33%) ⬆️
suricata-verify 61.69% <77.90%> (+0.16%) ⬆️
unittests 62.69% <34.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jasonish
Copy link
Member

jasonish commented Feb 2, 2024

@jasonish if I understand correctly, the question with this is if the C code should be formatted within the same commit than rust, what do you think ?

Maybe, or in the same batch. I've scripted a rustfmt into my scripts re-org/reformat of the C code as well.. Separate commit, but same batch. With the idea being that squash could be done just prior to merge.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.memcap_pressure 57 53 92.98%
.http.memuse 373800 404520 108.22%

Pipeline 18070

@catenacyber catenacyber added the needs rebase Needs rebase to master label Feb 12, 2024
@catenacyber catenacyber marked this pull request as draft February 12, 2024 14:24
@catenacyber
Copy link
Contributor Author

Will rebase when asked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
3 participants