dpdk: add warning in configuration phase and minor DPDK refactoring v2 #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 15, 2024 23:16
| @@ -349,7 +349,7 @@ static void ConfigSetIface(DPDKIfaceConfig *iconf, const char *entry_str) | |||
|
|
|||
| retval = rte_eth_dev_get_port_by_name(entry_str, &iconf->port_id); | |||
| if (retval < 0) | |||
| FatalError("Interface \"%s\": %s", entry_str, rte_strerror(-retval)); | |||
| FatalError("Name of the interface (%s) is invalid: %s", entry_str, rte_strerror(-retval)); | |||
There was a problem hiding this comment.
this message suggests the name itself is invalid, but is that what is meant here? A name can be valid w/o being present in the system?
There was a problem hiding this comment.
No, it was meant to say that the interface does not exist. Will reword.
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 18572 |
This was referenced Feb 16, 2024
|
#10472 has a followup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6739
v2 changes:
- (err %s)to: %sDescribe changes: