Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backports-7.0.x: dpdk: add interrupt (power-saving) mode v2 #10558

Conversation

lukashino
Copy link
Contributor

Follow-up of #10226

When the packet load is low, Suricata can run in interrupt mode. This more resembles the classic approach of processing packets - CPU cores run low and only fetch packets on interrupt.

https://redmine.openinfosecfoundation.org/issues/6696

Describe changes:
v2:

  • rebased

When the packet load is low, Suricata can run in interrupt
mode. This more resembles the classic approach of processing
packets - CPU cores run low and only fetch packets
on interrupt.

Ticket: OISF#6696
(cherry picked from commit 2a28980)
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (b6c609e) to head (1a1611d).

Additional details and impacted files
@@              Coverage Diff               @@
##           main-7.0.x   #10558      +/-   ##
==============================================
+ Coverage       82.43%   82.47%   +0.04%     
==============================================
  Files             976      976              
  Lines          275046   275046              
==============================================
+ Hits           226726   226839     +113     
+ Misses          48320    48207     -113     
Flag Coverage Δ
fuzzcorpus 63.56% <ø> (+0.10%) ⬆️
suricata-verify 61.66% <ø> (-0.02%) ⬇️
unittests 62.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 18937

@catenacyber
Copy link
Contributor

Was it a clean cherry-pick ?

@lukashino
Copy link
Contributor Author

yes, I think so, I don't remember redoing much.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work

CI : ✅
Code : clean cherry-pick
Commits segmentation : clean cherry-pick
Commit messages : clean cherry-pick with ticket updated to match the 7 one
Git ID set : ok
CLA : ok
Doc update : clean cherry-pick
Redmine ticket : ok
Rustfmt : not needed
Tests : how do you test this @lukashino ? With SV ?
Dependencies added: none

@victorjulien
Copy link
Member

Merged in #10793, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants