Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: add dns.rcode keyword - v10 #10584

Closed

Conversation

jufajardini
Copy link
Contributor

@jufajardini jufajardini commented Mar 5, 2024

Feature #6621

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6621

Previous PR: #10458

Describe changes from previous PR:

  • rebase
  • restructure commit message a bit (bring ticket number to last line, plus a couple of rewordings)
  • restructure doc section a bit (remove double "the", use capital for Suricata, remove whitespace at end of lines, mention requests and responses on both example explanations...)

To use a pull request use a branch name like pr/N where N is the
pull request number.

SV_BRANCH=OISF/suricata-verify#1687

dns.rcode matches the rcode header field in DNS messages
It's an unsigned integer
valid ranges = [0-15]
Does not support prefilter
Supports matches in both flow directions

Task OISF#6621
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 92.92035% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 82.69%. Comparing base (4afaadc) to head (f178db3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10584      +/-   ##
==========================================
- Coverage   82.74%   82.69%   -0.06%     
==========================================
  Files         924      925       +1     
  Lines      247401   247514     +113     
==========================================
- Hits       204719   204675      -44     
- Misses      42682    42839     +157     
Flag Coverage Δ
fuzzcorpus 64.02% <28.88%> (-0.09%) ⬇️
suricata-verify 61.89% <82.22%> (+0.01%) ⬆️
unittests 62.18% <71.68%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 18995

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien added this to the 8.0 milestone Mar 9, 2024
@victorjulien
Copy link
Member

Merged in #10603, thanks!

@jufajardini jufajardini deleted the detect-dns-rcode-6621-v10 branch March 11, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants