Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/330/20240307/v1 #10590

Merged
merged 3 commits into from Mar 8, 2024
Merged

Conversation

victorjulien
Copy link
Member

victorjulien and others added 3 commits March 7, 2024 21:02
Time locked to 0.3.20 to guarantee MSRV of 1.63.
Update snmp-parser to 0.10.0.
Update asn1-rs to 0.6.1.
Update kerberos-parser to 0.8.0.
Update x509-parser 0.16.0.
Update der-parser to 9.0.0.
Remove specific use of der-parser 6.

Ticket: OISF#6817.
Ticket: OISF#6818.
Commit b8b8aa6 used tm_name of the
first StatsRecord of a thread block as key for the "threads" object.
However, depending on the type of thread, tm_name can be NULL and would
result in no entry being included for that thread at all. This caused
non-worker metrics to vanish from the "threads" object in the
dump-counters output.

This patch fixes this by remembering the first occurrence of a valid
tm_name within the per-thread block and adds another unittest to
cover this scenario.
New suricata-verify test listens on loopback interface, resulting
in the capture and in_iface fields in the stats and event objects.
@victorjulien victorjulien requested review from jasonish and a team as code owners March 7, 2024 22:37
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 19063

@victorjulien victorjulien merged commit f9cf87a into OISF:master Mar 8, 2024
43 checks passed
@victorjulien victorjulien deleted the next/330/20240307/v1 branch March 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants