detect/port: bug-6843 - v2 #10602
Closed
detect/port: bug-6843 - v2 #10602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a port point is single but later on also a part of a range, it ends up only creating the port groups for single points and not the range. Fix it by adding the port next to current single one to unique points and marking it a range port. Bug 6843
inashivb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10602 +/- ##
===========================================
+ Coverage 62.20% 82.72% +20.51%
===========================================
Files 924 924
Lines 247158 247452 +294
===========================================
+ Hits 153741 204698 +50957
+ Misses 93417 42754 -50663
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 19160 |
victorjulien
approved these changes
Mar 9, 2024
Merged
|
Merged in #10608, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime on this PR:
vs
master:Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6843
SV_BRANCH=OISF/suricata-verify#1692
Changes since v1: