netmap: Avoid HW errors when using pipes #10605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 6837 When using netmap pipes (with lb, for example), avoid direct hardware related IOCTLs that will fail (not supported with pipes). (cherry picked from commit af529a5)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #10605 +/- ##
==============================================
- Coverage 82.44% 82.43% -0.02%
==============================================
Files 976 976
Lines 275049 275049
==============================================
- Hits 226770 226738 -32
- Misses 48279 48311 +32
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 19166 |
victorjulien
approved these changes
Mar 9, 2024
|
Merged in #10620, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-7.0.x backport for issue: 6837
When using netmap pipes (with lb, for example), avoid direct hardware related IOCTLs that will fail (not supported with pipes).
(cherry picked from commit af529a5)
Link to redmine ticket: 6842
Describe changes:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.