Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0.x backport: Fix stats missing for non workers #10742

Closed
wants to merge 2 commits into from
Closed

7.0.x backport: Fix stats missing for non workers #10742

wants to merge 2 commits into from

Commits on Mar 31, 2024

  1. stats: Fix non-worker stats missing 

    Commit b8b8aa6 used tm_name of the
first StatsRecord of a thread block as key for the "threads" object.
However, depending on the type of thread, tm_name can be NULL and would
result in no entry being included for that thread at all. This caused
non-worker metrics to vanish from the "threads" object in the
dump-counters output.

This patch fixes this by remembering the first occurrence of a valid
tm_name within the per-thread block and adds another unittest to
cover this scenario.

(cherry picked from commit f172041)
    @awelzel @jlucovsky
    awelzel authored and jlucovsky committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    87b5185 View commit details
    Browse the repository at this point in the history

  2. schema: Add stats.capture and in_iface properties 

    New suricata-verify test listens on loopback interface, resulting
in the capture and in_iface fields in the stats and event objects.

(cherry picked from commit f9cf87a)
    @awelzel @jlucovsky
    awelzel authored and jlucovsky committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    41c94b7 View commit details
    Browse the repository at this point in the history