Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert syslog/v1 #10762

Closed
wants to merge 4 commits into from
Closed

Alert syslog/v1 #10762

wants to merge 4 commits into from

Conversation

victorjulien
Copy link
Member

Some cleanups.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 19928

This was referenced Apr 9, 2024
Closed
Closed
@catenacyber
Copy link
Contributor

Does this need a rebase to get green CI on MacOS ?

@victorjulien
Copy link
Member Author

It's part of the green #10796

@catenacyber
Copy link
Contributor

But it is not obvious if this was fixed by another of the 45 commits of #10796 :-p

jasonish
jasonish approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks OK. I'm now curious where syslog is not thread-safe. POSIX states that it should be.

@victorjulien victorjulien mentioned this pull request Apr 11, 2024
Closed
@victorjulien
Copy link
Member Author

All looks OK. I'm now curious where syslog is not thread-safe. POSIX states that it should be.

Haven't investigated, not planning to either. Locking was already there, just tightened it a bit.

Replaced by #10806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@victorjulien @suricata-qa @catenacyber @jasonish