Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix and test with Wunused-macros #10804

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6937

Describe changes:

  • Remove unused macros as reported by compiler with -Wunused-macros and test in CI with default C flags

Draft as there are still some to remove, but would like to see CI

@suricata-qa
Copy link

WARNING:

field baseline test %
build_asan

Pipeline 20008

@catenacyber catenacyber force-pushed the compile-wunused-macros-6937-v1 branch from 4f0efcc to 3065e1e Compare April 11, 2024 14:25
@suricata-qa
Copy link

WARNING:

field baseline test %
build_asan

Pipeline 20009

@catenacyber catenacyber force-pushed the compile-wunused-macros-6937-v1 branch 2 times, most recently from f3189e9 to 7c9d2c8 Compare April 11, 2024 15:04
@catenacyber catenacyber force-pushed the compile-wunused-macros-6937-v1 branch from 7c9d2c8 to e9c3500 Compare April 11, 2024 16:06
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.76%. Comparing base (d9148d1) to head (f5eee2d).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10804      +/-   ##
==========================================
+ Coverage   82.73%   82.76%   +0.02%     
==========================================
  Files         927      928       +1     
  Lines      247785   247914     +129     
==========================================
+ Hits       204996   205176     +180     
+ Misses      42789    42738      -51     
Flag Coverage Δ
fuzzcorpus 64.23% <83.33%> (+0.05%) ⬆️
suricata-verify 62.01% <66.66%> (+0.02%) ⬆️
unittests 62.18% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber
Copy link
Contributor Author

Replaced by #10808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants