Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defrag: fix wrong datalink being logged #10807

Closed
wants to merge 1 commit into from

Conversation

victorjulien
Copy link
Member

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.76%. Comparing base (172b55c) to head (478198c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10807   +/-   ##
=======================================
  Coverage   82.75%   82.76%           
=======================================
  Files         928      928           
  Lines      247913   247915    +2     
=======================================
+ Hits       205162   205176   +14     
+ Misses      42751    42739   -12     
Flag Coverage Δ
fuzzcorpus 64.23% <100.00%> (+<0.01%) ⬆️
suricata-verify 62.01% <100.00%> (+<0.01%) ⬆️
unittests 62.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber
Copy link
Contributor

How do you test this ?
How gets datalink field used ?

@victorjulien
Copy link
Member Author

How do you test this ? How gets datalink field used ?

It's logged in eve and tells you the data type of the packet logging. So if there is an ethernet header, the datalink should reflect that, instead of claiming RAW (so first byte is start of the IP header)

@victorjulien victorjulien added this to the 8.0 milestone Apr 11, 2024
@catenacyber
Copy link
Contributor

So, is there a SV test for this fix ?

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPR1_suri_time.

field baseline test %
SURI_TLPR1_stats_chk
.uptime 645 691 107.13%

Pipeline 20016

@victorjulien
Copy link
Member Author

victorjulien commented Apr 12, 2024

So, is there a SV test for this fix ?

OISF/suricata-verify#1756

Replaced by #10817.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants