Bug 6726 livedev ips/v3 #10863
Closed
Bug 6726 livedev ips/v3 #10863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve it for af-packet, dpdk, netmap. Check would not consider an interface IDS if the `default` section contained a copy-mode field.
In general, improve IPS setup error checking. Ticket: OISF#5588.
For the capture methods that support livedev and IPS, error out if livedev.use-for-tracking is set to true. This setting causes major flow tracking issues, as both sides of a flow would be tracked in different flows. Ticket: OISF#6726.
|
Tested 3 scenarios:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10863 +/- ##
=======================================
Coverage 82.95% 82.96%
=======================================
Files 917 917
Lines 247361 247347 -14
=======================================
+ Hits 205198 205203 +5
+ Misses 42163 42144 -19
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Guess it works ;) |
|
Closing in favor of #10864, which is a more user friendly approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/issues/5588
https://redmine.openinfosecfoundation.org/issues/6726