detect/http-server-body: avoid FP on toserver direction #10879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6948 http.response_body keyword did not enforce a direction, and thus could match on files sent with POST requests
catenacyber
commented
Apr 17, 2024
| @@ -124,6 +124,9 @@ static int DetectHttpServerBodySetupSticky(DetectEngineCtx *de_ctx, Signature *s | |||
| return -1; | |||
| if (DetectSignatureSetAppProto(s, ALPROTO_HTTP) < 0) | |||
| return -1; | |||
| // file data is on both directions, but we only take the one to client here | |||
| s->flags |= SIG_FLAG_TOCLIENT; | |||
| s->flags &= ~SIG_FLAG_TOSERVER; | |||
There was a problem hiding this comment.
I tried to do as flow:to_client
I did not want to error on s->flags & SIG_FLAG_TOSERVER as we can have s->flags = SIG_FLAG_TOSERVER | SIG_FLAG_TOCLIENT
But not 100% sure...
There was a problem hiding this comment.
I think it makes sense.
Could you add a SV test that checks the engine analysis as well? Similar to https://github.com/OISF/suricata-verify/tree/master/tests/rules
There was a problem hiding this comment.
Done in OISF/suricata-verify#1784
victorjulien
approved these changes
Apr 18, 2024
Closed
Closed
Merged
|
Merged in #10921, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6948
Describe changes:
SV_BRANCH=OISF/suricata-verify#1784