Pkt ptrs/v42 #10926
Closed
Pkt ptrs/v42 #10926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match function naming style.
Replace it with inline functions. Adds inline functions to wrap PKT_IS_IPV4/PKT_IS_IPV6. This is in preparation of removing the macro's, and cleaning up the header pointers.
Improve readability by setting up data/data_len once before passing on to the other decoders. Work in preparation of other decoder changes.
In preparation of future Packet structure changes.
In preparation of making them union members.
Take less space in the TCPVars for tracking if SACKOK is set. Reduces size by 16 bytes.
No longer use a pointer, but rather an offset.
SET_OPTS is now unused, so remove.
Addresses are pulled from embedded IPv4 header directly. Embeded hlen was unused.
Remove unused L4 header pointers.
Not used, so no need to keep them.
Only used in tests. For the tests, switch to getting headers from embedded IPv6 header.
Was only set, never checked.
Use a flag to indicate a calculated csum is available. Allows packet reset to just use memset.
Replace PKT_IS_UDP macro with PacketIsUDP inline function.
Also start vars section in L4 for icmpv6vars.
Remove header pointer from Packet as there were no users of it.
Remove from Packet struct as there were no users of it.
Reduce gaps in the structure.
Closed
Avoid NULL pointer calculations.
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10926 +/- ##
==========================================
+ Coverage 82.74% 82.80% +0.06%
==========================================
Files 922 921 -1
Lines 247861 247770 -91
==========================================
+ Hits 205081 205168 +87
+ Misses 42780 42602 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPW1_files_sha256. Pipeline 20215 |
Closed
|
Replaced by #10953. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10908 rebased, with int fixups.