output: Add linktype description #10956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amend the linktype output with the linktype name (when available). The linktype name is included alongside linktype when `alert.packet` is enabled. The name is retrieved from pcap_datalink_val_to_name with the thought being that the pcap library in use can also translate the linktype value into a descriptive value.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10956 +/- ##
==========================================
- Coverage 82.94% 82.93% -0.01%
==========================================
Files 918 918
Lines 248784 248787 +3
==========================================
- Hits 206351 206340 -11
- Misses 42433 42447 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Closing for reevaluation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend the linktype output with the linktype name (when available).
The linktype name is included alongside linktype when
alert.packetis enabled. The name is retrieved from pcap_datalink_val_to_name with the thought being that the pcap library in use can also translate the linktype value into a descriptive value.Link to redmine ticket: 6954
Describe changes:
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#1798