issue 1486: better error message in likely missing semicolon - v2 #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a rule option value starts with a double quote, ensure it ends with a double quote, exclusive of white space which gets trimmed anyways. Catches errors like 'filemagic:"picture" sid:5555555;' reporting that a missing semicolon may be the error.
inliniac
reviewed
Sep 22, 2016
| break; | ||
| } | ||
| } | ||
| if (optvalue[ovlen - 1] != '"') { |
There was a problem hiding this comment.
detect-parse.c: In function ‘SigParse’:
detect-parse.c:624:25: error: array subscript is above array bounds [-Werror=array-bounds]
if (optvalue[ovlen - 1] != '"') {
^
|
Trying to get the warning myself (not that there isn't a problem, I just want to make sure the error goes away as well). I'm using gcc 6.1.1 and clang 3.9.0, with -Werror=array-bounds. What are you using? |
|
On 22-09-16 16:09, Jason Ish wrote:
This was on a Debian box, think it's clang 3.5. Saw it with gcc |
|
Bounds fixed in new PR: #2265 |
Merged
|
I merged the pcre cleanup commits in #2266, thanks Jason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to detect missing semicolons by detecting unbalanced double quotes. Can give a more meaningful error message.
Redmine issue: https://redmine.openinfosecfoundation.org/issues/1486
Final commit includes conversion to unit test macros. I couldn't resist after having to fix up one test.
Prscript: