TLS logging for session resumption 1.3 #2562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assume session resumption has occurred if the Client Hello message included a session id, we have not seen the server certificate, but we have seen a Change Cipher Spec message from the server. Previously, these transactions were not logged at all because the server cert was never seen. https://redmine.openinfosecfoundation.org/issues/1969
|
@thus I'll consider this once you sign off on it |
|
@inliniac: It looks good to me. |
|
I missed this previously: as a EVE option is added we'll need an update to the docs as well. |
|
https://github.com/inliniac/suricata/blob/master/doc/userguide/output/eve/eve-json-format.rst should be updated, but it should probably wait until https://github.com/inliniac/suricata/pull/2568/files#diff-7823d9d82df45a9858e8925a6259022e is merged (or a newer version of it) |
|
@inliniac To clarify, should I resubmit this PR with the requested doc updates? |
|
On 20-02-17 19:26, Ray Ruvinskiy wrote:
@inliniac <https://github.com/inliniac> To clarify, should I resubmit
this PR with the requested doc updates?
Yes please! Thanks!
|
|
Per your suggestion, I'll resubmit after #2580 or its successor is merged. Thanks! |
|
Replaced by #2602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assume session resumption has occurred if the Client Hello message included
a session id, we have not seen the server certificate, but we have seen a
Change Cipher Spec message from the server.
Previously, these transactions were not logged at all because the server cert
was never seen.
https://redmine.openinfosecfoundation.org/issues/1969
Replaces #2555