rule-reload: fix possible hangup with SIGUSR2 #3086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the rule reload could hang. The pending USR2 signals will be recognized even with the <2 check. Also the SCLogWarning shouldn't be used in the handler (see Warning about SCLog* API above in the code).
Merged
|
Merged in #3093, thanks! |
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Jan 31, 2021
Detects and parses the bittorrent-dht protocol. Feature: OISF#3086
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Jan 31, 2021
Detects and parses the bittorrent-dht protocol. Feature: OISF#3086
3 tasks
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Feb 2, 2021
Detects and parses the bittorrent-dht protocol. Feature: OISF#3086
3 tasks
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Feb 12, 2021
Detects and parses the bittorrent-dht protocol. Feature: OISF#3086
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Feb 26, 2021
Detects and parses the bittorrent-dht protocol. Feature: OISF#3086
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Feb 28, 2021
Detects and parses the bittorrent-dht protocol. Feature: OISF#3086
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Feb 28, 2021
Detects and parses the bittorrent-dht protocol. Feature: OISF#3086
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Feb 28, 2021
Parses and logs the bittorrent-dht protocol. Feature: OISF#3086
3 tasks
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Oct 18, 2021
Parses and logs the bittorrent-dht protocol. Feature: OISF#3086
abungay
added a commit
to abungay/suricata
that referenced
this pull request
Oct 18, 2021
Parses and logs the bittorrent-dht protocol. Feature: OISF#3086
3 tasks
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Aug 10, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Aug 10, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Aug 12, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 8, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 13, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 29, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 29, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 29, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 29, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 29, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 29, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 29, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 29, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Sep 30, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Oct 4, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Oct 4, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Oct 5, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Oct 27, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Oct 28, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
benignbala
pushed a commit
to benignbala/suricata
that referenced
this pull request
Nov 12, 2022
Parses and logs the bittorrent-dht protocol. Note: Includes some compilation fixups after rebase by Jason Ish. Feature: OISF#3086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the rule reload could hang. The pending USR2 signals will
be recognized even with the <2 check. Also the SCLogWarning shouldn't be
used in the handler (see Warning about SCLog* API above in the code).
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2361
Describe changes:
up to two SIGUSR2 signals are enough and the warning about SCLog API should be followed
PRScript output (if applicable):