af_packet: bug #2422. #3174
Closed
af_packet: bug #2422. #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a leak of mmap'ed ring buffer that was not unmaped when a socket was closed. In addition, the leak could break an inline channel on certain configurations. Also slightly changed AFPCreateSocket(): 1. If an interface is not up, it does not try to apply any settings to a socket. This reduces a number of error messages while an interface is down. 2. Interface is considered active if both IFF_UP and IFF_RUNNING are present.
|
Anyone? :) |
regit
approved these changes
Jan 23, 2018
| @@ -1533,9 +1536,9 @@ static int AFPGetIfnumByDev(int fd, const char *ifname, int verbose) | |||
| strlcpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name)); | |||
|
|
|||
| if (ioctl(fd, SIOCGIFINDEX, &ifr) == -1) { | |||
| if (verbose) | |||
There was a problem hiding this comment.
Please avoid mixing fix and whitespace commit. But it is ok for this time ;)
|
Merged through #3184, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug 2422
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2422
Describe changes: