Parser the dyn_port when in FTP active mode #3302
Conversation
…rt, but current code doesn't parse it. So add a new method FTPParseGetDynPort to handler dyn_port, and call it in the case FTP_COMMAND_PORT.
|
Hi, please have a look at the contribution agreement. If you have any questions or concerns contact me by email at vjulien@oisf.net |
|
I have sent the mail to you, please check inbox. |
| @@ -425,6 +453,8 @@ static int FTPParseRequest(Flow *f, void *ftp_state, | |||
| memcpy(state->port_line, state->current_line, | |||
| state->current_line_len); | |||
| state->port_line_len = state->current_line_len; | |||
| // TODO need to handle ipv6 | |||
| FTPParseGetDynPort(state, input, input_len); | |||
There was a problem hiding this comment.
Why can't you call directly FTPParsePassiveResponse ? The pointer to the Flow is also available here available. At worse if the parsing is the same, you can rename the function.
There was a problem hiding this comment.
Because I hope the method FTPParseGetDynPort can be used in FTP active and passive both. And sorry, i don't know rust, so i don't know how to handle it.
| @@ -1328,4 +1335,3 @@ void FTPParserRegisterTests(void) | |||
| UtRegisterTest("FTPParserTest10", FTPParserTest10); | |||
| #endif /* UNITTESTS */ | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please, no whitespace fixes in a functional commit.
There was a problem hiding this comment.
OK, but i didn't add it, maybe my IDE did it.
| uint16_t dyn_port; | ||
|
|
||
| #ifdef HAVE_RUST | ||
| dyn_port = rs_ftp_pasv_response(input, input_len); |
There was a problem hiding this comment.
This won't work in rust because the rust parsing function is looking for something starting with 227 response code.
There was a problem hiding this comment.
Sorry, i don't know rust, so can anybody help me to add a method rs_ftp_active_response in the rust file?
There was a problem hiding this comment.
You can skip the rust code and use some C code only if you refactor a bit. But rust is not that complicated if you have example.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
Describe changes:
PRScript output (if applicable):