New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LZ4 compression for pcap logs #3340
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the option 'outputs.pcap-log.compression' which can be set to 'none' or 'lz4', plus options to set the compression level and to enable checksums. SCFmemopen is used to make pcap_dump() write to a buffer which is then compressed using liblz4.
Not sure about the Fedora case...
jasonish
approved these changes
Apr 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue addressed. I'm going to fixup the commit to configure.ac to make it correct for Fedora, plus a spelling mistake.
Rebased and correct configure instructions for Fedora: #3357 |
I can close this one now, right? |
Replaced by #3357 |
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Nov 18, 2019
glongo
added a commit
to glongo/suricata
that referenced
this pull request
Nov 19, 2019
Like bug OISF#3340, SIP TCP transactions are logged with source and destination addresses swapped. But in this case logging logic needed to be reworkerd, because source and destination addresses were not logged correctly with regard to the flow direction. In this example below, there are 2 requests and 1 response but source and destination addresses are not correct. {"timestamp":"2019-11-17T07:43:57.799196-0600","flow_id":56712067097706,"pcap_cnt":5,"event_type":"sip","src_ip":"192.168.43.1","src_port":43168,"dest_ip":"192.168.43.100","dest_port":5060,"proto":"TCP", "sip":{"method":"REGISTER","uri":"sip:192.168.43.100;transport=TCP","version":"SIP/2.0","request_line":"REGISTER sip:192.168.43.100;transport=TCP SIP/2.0"}} {"timestamp":"2019-11-17T07:43:57.802382-0600","flow_id":56712067097706,"pcap_cnt":7,"event_type":"sip","src_ip":"192.168.43.1","src_port":43168,"dest_ip":"192.168.43.100","dest_port":5060,"proto":"TCP", "sip":{"version":"SIP/2.0","code":"200","reason":"OK","response_line":"SIP/2.0 200 OK"}} {"timestamp":"2019-11-17T07:43:57.806796-0600","flow_id":56712067097706,"pcap_cnt":9,"event_type":"sip","src_ip":"192.168.43.1","src_port":43168,"dest_ip":"192.168.43.100","dest_port":5060,"proto":"TCP", "sip":{"method":"REGISTER","uri":"sip:192.168.43.100;transport=TCP","version":"SIP/2.0","request_line":"REGISTER sip:192.168.43.100;transport=TCP SIP/2.0"}}
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Nov 29, 2019
Ticket OISF#3340. https://redmine.openinfosecfoundation.org/issues/3340 (cherry picked from commit fccbd36)
catenacyber
pushed a commit
to catenacyber/suricata
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2456
Describe changes:
Update to #3188, #3200, #3206, #3250, #3283, and #3285