Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smtp: improve pipelining support #3568

Closed

Conversation

catenacyber
Copy link
Contributor

Fixes #1863

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/1863

Describe changes: Improve SMTP pipelining support

  • Checks if the server includes pipelining support in its first multi-line reply
  • Then , enter data mode immediately after the DATA command, without waiting for the server confirmation

PRScript output (if applicable): not applicable

Either checking state has pipelining
Or removing pipelining from input
@catenacyber catenacyber requested a review from a team as a code owner December 5, 2018 09:23
@victorjulien
Copy link
Member

Thanks Philippe! Could you also submit a test to https://github.com/OISF/suricata-verify ?

@catenacyber
Copy link
Contributor Author

I modified SMTPParserTest03 in src/app-layer-smtp.c (whose comment was "Testing parsing pipelined commands")
Is that ok ?

@victorjulien
Copy link
Member

If you can find (or create) a pcap, I would prefer to add that as well.

@catenacyber
Copy link
Contributor Author

Ok, see OISF/suricata-verify#5

@victorjulien victorjulien mentioned this pull request Dec 19, 2018
@victorjulien
Copy link
Member

Merged as part of #3590, thanks Philippe!

@catenacyber catenacyber deleted the smtp-pipelining-data-1863-v1 branch September 4, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants