filestore v2: print sid in json output (Optimization #2530) v7 #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magenbluten
changed the title
magenbluten
changed the title
| @@ -149,6 +149,18 @@ json_t *JsonBuildFileInfoRecord(const Packet *p, const File *ff, | |||
| json_object_set_new(fjs, "filename", SCJsonString(s)); | |||
| if (s != NULL) | |||
| SCFree(s); | |||
|
|
|||
| json_t *sig_ids = json_array(); | |||
| if (unlikely(fjs == NULL)) { | |||
There was a problem hiding this comment.
this should check sig_ids I think. I'll fix it up
Closed
|
Merged in #3673 with the fix I mentioned above, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2530
Describe changes:
PRScript output (if applicable):