rule-analyzer: Ensure content counts are accurate #3752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue 2605. Make sure that content is counted, even if none of the specific content types are matched.
| @@ -1246,7 +1248,7 @@ void EngineAnalysisRules(const DetectEngineCtx *de_ctx, | |||
| if (warn_encoding_norm_http_buf) { | |||
| fprintf(rule_engine_analysis_FD, " Warning: Rule may contain percent encoded content for a normalized http buffer match.\n"); | |||
| } | |||
| if (warn_tcp_no_flow /*rule_flow == 0 && rule_flow == 0 | |||
| if (warn_tcp_no_flow /*rule_flow == 0 && rule_flags == 0 | |||
There was a problem hiding this comment.
What is this change? Is it related to the counting?
There was a problem hiding this comment.
The comment was incorrect -- it's tracking the code at https://github.com/OISF/suricata/blob/master/src/detect-engine-analyzer.c#L1128
Merged
|
Merged in #3772, thanks Jeff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 2605. Make sure that content is counted,
even if none of the specific content types are matched.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2605
Describe changes: