compile: checks libhtp lzma support #4163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails on this, can you check why? |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Aug 18, 2022
Ticket: OISF#4163.
benignbala
pushed a commit
to benignbala/suricata
that referenced
this pull request
Nov 12, 2022
Ticket: OISF#4163.
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jul 6, 2023
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jul 6, 2023
New minimum Rust version: 1.63.0. Current latest known good version: 1.70.0. Add test specifically for MSRV as we didn't have one. Ticket: OISF#4163
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jul 6, 2023
New minimum Rust version: 1.63.0. Current latest known good version: 1.70.0. Add test specifically for MSRV as we didn't have one. Ticket: OISF#4163
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jul 7, 2023
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jul 7, 2023
New minimum Rust version: 1.63.0. Current latest known good version: 1.70.0. Add test specifically for MSRV as we didn't have one. Ticket: OISF#4163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
none
Describe changes:
In the case of a non bundled version, we run a program creating a decompressor with
HTP_COMPRESSION_LZMA(this checks if the version is recent enough) and then checks if it is not in passthrough mode (in case the recent version was compiled on a machine without liblzma)In the case of bundled version, we just check that the version is recent enough to have HTP_COMPRESSION_LZMA in headers (liblzma check is already done).