Mpls fixes v4 #4311
Closed
Mpls fixes v4 #4311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've cherry-picked 36f4a2d, thanks Wesley. I want to redesign how we store multiple id's in the packet before considering the rest of this. |
|
Quick update. I've pushed #4977 for as RFC. This would handle storage of arbitrary number of labels (among other things) w/o taking any space when no MPLS is in use. |
|
@victorjulien Some changes from this PR have been merged. Should the PR remain open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2771
https://redmine.openinfosecfoundation.org/issues/2772
Describe changes:
Applied review comments in PR: #3675