Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python lgtmfix v3 #4397

Closed
wants to merge 4 commits into from
Closed

Python lgtmfix v3 #4397

wants to merge 4 commits into from

Conversation

catenacyber
Copy link
Contributor

Found by lgtm.com

Link to redmine ticket:
None

Describe changes:

  • Fixes regular expression in rust/gen-c-headers.py
  • Various python style improvements

Follows #4396 with needed rebase for suricata-verify tests to pass

inashivb
inashivb approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its funny to write but LGTM.
Thanks, @catenacyber ! :)

@victorjulien victorjulien added this to the 6.0 milestone Feb 11, 2020
@victorjulien
Copy link
Member

Can you rebase this Philippe?

@catenacyber catenacyber mentioned this pull request Feb 12, 2020
Closed
@catenacyber catenacyber deleted the python-lgtmfix-v3 branch March 5, 2020 21:31
victorjulien added a commit to victorjulien/suricata that referenced this pull request Mar 12, 2021
@victorjulien
eve/drop: use highest priority drop
398ebf9 
When adding the alert to a drop record make sure the add the highest
priority.

It would until now add all drops from high to low prio, effectively
overwriting the record each time.

Ticket OISF#4397
inashivb pushed a commit to inashivb/suricata that referenced this pull request Apr 29, 2021
@victorjulien @inashivb
eve/drop: use highest priority drop
7ca30e5 
When adding the alert to a drop record make sure the add the highest
priority.

It would until now add all drops from high to low prio, effectively
overwriting the record each time.

Ticket OISF#4397

(cherry picked from commit 398ebf9)
jlucovsky pushed a commit to jlucovsky/suricata that referenced this pull request May 1, 2021
@victorjulien @jlucovsky
eve/drop: use highest priority drop
9ccab5b 
When adding the alert to a drop record make sure the add the highest
priority.

It would until now add all drops from high to low prio, effectively
overwriting the record each time.

Ticket OISF#4397

(cherry picked from commit 398ebf9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlucovsky jlucovsky jlucovsky approved these changes

@inashivb inashivb inashivb approved these changes

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien

Assignees

@inashivb inashivb

Labels
None yet
Milestone
6.0
4 participants
@catenacyber @victorjulien @jlucovsky @inashivb