Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Improve tos description #4914

Closed
wants to merge 1 commit into from
Closed

Conversation

jlucovsky
Copy link
Contributor

This commit improves the description of the tos keyword by emphasizing
that the value used should adhere to the guidelines in RFC2474. Instead
of specifying the DSCP value directly, right shift the DSCP value and
use that.

Link to redmine ticket: 3638

Describe changes:

  • Emphasize how to specify DSCP values and ensure RFC is adhered to.

This commit improves the description of the `tos` keyword by emphasizing
that the value used should adhere to the guidelines in RFC2474. Instead
of specifying the DSCP value directly, right shift the DSCP value and
use that.
@jlucovsky jlucovsky requested a review from norg as a code owner May 2, 2020 14:12
Copy link
Member

@norg norg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorjulien victorjulien mentioned this pull request Jun 9, 2020
@victorjulien
Copy link
Member

Merged in #5047, thanks Jeff!

@jlucovsky jlucovsky deleted the 3638/1 branch June 9, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants