New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testimony feature 3675 v3 #4924
Closed
MalakhatkoVadym
wants to merge
4
commits into
OISF:master
from
MalakhatkoVadym:testimony-feature-3675-v3
Closed
Testimony feature 3675 v3 #4924
MalakhatkoVadym
wants to merge
4
commits into
OISF:master
from
MalakhatkoVadym:testimony-feature-3675-v3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Dec 21, 2021
It appears that DNS servers will still process a DNS request even if the z-bit is set, our parser will fail the transaction. So create the transaction, but still set the event. Ticket OISF#4924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3675
Describe changes:
Testimony is a single-machine, multi-process architecture for sharing AF_PACKET data across processes.
https://github.com/google/testimony
Modifies #4923 by adding placeholders for TmModuleReceiveTestimonyRegister and TmModuleDecodeTestimonyRegister functions if testimony is not enabled and adding hints for user if --testimony option is present but testimony is disabled.
Testing
I tested with 2 testimonyd's running:
sudo testimonyd --config=/etc/testimony.conf
interface - "eth0"
socket path - "/tmp/testimony.sock"
Fanout size - "4" (packets are balanced between 4 memory blocks, so suricata can use receive thread for each memory block).
sudo testimonyd --config=/etc/testimony2.conf
interface - "eth1"
socket path - "/tmp/testimony2.sock"
Fanout size - "1" (packets are not balanced between memory blocks).
sudo suricata -c /etc/suricata/suricata.yaml -k none --testimony=/tmp/testimony.sock --testimony=/tmp/testimony2.sock
suricata.yaml :