ftp/eve: Convert to JsonBuilder #5049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6ec8224)
I think this is a bad use of transmute, while the end result is the same, Box::from_raw is more correct as we created this pointer with Box::into_raw. (cherry picked from commit 40b1f51)
This commit converts the FTP logging mechanisms to use JsonBuilder.
This commit removes an unused helper function no longer required/used after conversion to JsonBuilder.
jasonish
reviewed
Jun 12, 2020
Comment on lines
+142
to
+147
| fail: | ||
| if (js_resplist) { | ||
| jb_free(js_resplist); | ||
| } else { | ||
| jb_free(js_respcode_list); | ||
| } |
Opened issue 3770 to track. |
|
Continued in #5070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5030
Link to redmine ticket: 3714
Describe changes:
jb_set_string_from_bytes#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: