rust/rdp: Fix use of incorrect buffer #5274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the connection confirmation parsing function to use the correct buffer when determining the packet type.
Merged
|
Merged in #5276, thanks! |
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
May 6, 2022
We want to be able to share _some_ calls related to the unittests functions, but not the whole thing. When documentation for static functions is enabled in doxygen, the caller graphs can become huge, for all unittests that are involved in the caller graph will show up. To prevent this, removing UNITTESTS from PREDEFINED setting was necessary. With this change, only the RunUnittests function is shown in caller graphs. Related to Task OISF#5274
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the connection confirmation parsing function to use
the correct buffer when determining the packet type.
Link to redmine ticket: 3813
Describe changes:
PRScript output (if applicable):
#suricata-verify-pr: 297
#suricata-verify-repo: https://github.com/jlucovsky/suricata-verify
#suricata-verify-branch: 3339/2
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: